Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 017F111D1E for ; Tue, 19 Aug 2014 01:57:29 +0000 (UTC) Received: (qmail 21793 invoked by uid 500); 19 Aug 2014 01:57:28 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 21728 invoked by uid 500); 19 Aug 2014 01:57:28 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 21713 invoked by uid 99); 19 Aug 2014 01:57:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Aug 2014 01:57:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 23B661DBD77; Tue, 19 Aug 2014 01:57:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4515356378305832563==" MIME-Version: 1.0 Subject: Re: Review Request 24834: HIVE-7771: ORC PPD fails for some decimal predicates From: "Gopal V" To: "Gunther Hagleitner" , "Gopal V" Cc: j.prasanth.j@gmail.com, "hive" Date: Tue, 19 Aug 2014 01:57:27 -0000 Message-ID: <20140819015727.7608.98574@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gopal V" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/24834/ X-Sender: "Gopal V" References: <20140819013204.7608.96955@reviews.apache.org> In-Reply-To: <20140819013204.7608.96955@reviews.apache.org> Reply-To: "Gopal V" X-ReviewRequest-Repository: hive-git --===============4515356378305832563== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24834/#review50950 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java Does this imply an immediate return? Is there are reason we go through the type coercion codepaths after getting the value out of the object? - Gopal V On Aug. 19, 2014, 1:32 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24834/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2014, 1:32 a.m.) > > > Review request for hive, Gopal V and Gunther Hagleitner. > > > Repository: hive-git > > > Description > ------- > > Some queries like > {code} > select * from table where dcol<=11.22BD; > {code} > fails when ORC predicate pushdown is enabled. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb > ql/src/test/queries/clientpositive/orc_ppd_decimal.q a93590e > ql/src/test/results/clientpositive/orc_ppd_decimal.q.out 0c11ea8 > > Diff: https://reviews.apache.org/r/24834/diff/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > > --===============4515356378305832563==--