Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B2ED6118BB for ; Sun, 17 Aug 2014 22:00:08 +0000 (UTC) Received: (qmail 31312 invoked by uid 500); 17 Aug 2014 22:00:08 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 31225 invoked by uid 500); 17 Aug 2014 22:00:07 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 31209 invoked by uid 99); 17 Aug 2014 22:00:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 17 Aug 2014 22:00:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ECAAC1DBD20; Sun, 17 Aug 2014 22:00:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5043062227721167699==" MIME-Version: 1.0 Subject: Re: Review Request 24763: HIVE-7606: Design SparkSession, SparkSessionManager From: "Venki Korukanti" To: "Szehon Ho" , "Brock Noland" Cc: "Venki Korukanti" , "hive" Date: Sun, 17 Aug 2014 22:00:06 -0000 Message-ID: <20140817220006.7621.38297@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Venki Korukanti" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/24763/ X-Sender: "Venki Korukanti" References: <20140816020225.5174.43997@reviews.apache.org> In-Reply-To: <20140816020225.5174.43997@reviews.apache.org> Reply-To: "Venki Korukanti" X-ReviewRequest-Repository: hive-git --===============5043062227721167699== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24763/ ----------------------------------------------------------- (Updated Aug. 17, 2014, 10 p.m.) Review request for hive, Brock Noland and Szehon Ho. Changes ------- Includes review changes. Repository: hive-git Description ------- Please see JIRA HIVE-7606 for description Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 5ac5a25 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSession.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManager.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 9798cf3 ql/src/test/org/apache/hadoop/hive/ql/exec/spark/session/TestSparkSessionManagerImpl.java PRE-CREATION service/src/java/org/apache/hive/service/server/HiveServer2.java 0864dfb Diff: https://reviews.apache.org/r/24763/diff/ Testing ------- Added unittests to test SessionManagerImpl in single session mode (HiveCLI) and multi-session mode (HiveServer2). Also tested few queries from Hive CLI. Testing using actual HiveServer2 is blocked due to HIVE-7747. Thanks, Venki Korukanti --===============5043062227721167699==--