Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============4926620368511903201=="
MIME-Version: 1.0
Subject: Re: Review Request 24763: HIVE-7606: Design SparkSession,
 SparkSessionManager
From: "Venki Korukanti" <venki.korukanti@gmail.com>
To: "Szehon Ho" <szehon@cloudera.com>, "Brock Noland" <brock@cloudera.com>
Cc: "Venki Korukanti" <venki.korukanti@gmail.com>,
 "hive" <dev@hive.apache.org>
Date: Sun, 17 Aug 2014 21:58:34 -0000
Message-ID: <20140817215834.7609.77756@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Venki Korukanti" <noreply@reviews.apache.org>
References: <20140817181018.7621.33651@reviews.apache.org>
In-Reply-To: <20140817181018.7621.33651@reviews.apache.org>
Reply-To: "Venki Korukanti" <venki.korukanti@gmail.com>

--===============4926620368511903201==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Aug. 17, 2014, 6:10 p.m., Brock Noland wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java, line 177
> > <https://reviews.apache.org/r/24763/diff/1/?file=661979#file661979line177>
> >
> >     createdSessions.clear()?

Added createdSessions.clear()


> On Aug. 17, 2014, 6:10 p.m., Brock Noland wrote:
> > ql/src/test/org/apache/hadoop/hive/ql/exec/spark/session/TestSparkSessionManagerImpl.java, line 32
> > <https://reviews.apache.org/r/24763/diff/1/?file=661981#file661981line32>
> >
> >     Random is threadsafe on the Oracle JVM but it's not guranteed to be thread safe by the spec. Should we move this class into the inner class so our IBM friends won't have to fix this, if their version is not thread safe?

Moved inside the Run method.


> On Aug. 17, 2014, 6:10 p.m., Brock Noland wrote:
> > ql/src/test/org/apache/hadoop/hive/ql/exec/spark/session/TestSparkSessionManagerImpl.java, line 77
> > <https://reviews.apache.org/r/24763/diff/1/?file=661981#file661981line77>
> >
> >     Should we use a logger instead?

Added a logger. Currently only error messages go to the Logger. Tests checkpoint/msgs still print to stdout that way hive.log is clean.


- Venki


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24763/#review50843
-----------------------------------------------------------


On Aug. 16, 2014, 2:02 a.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24763/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2014, 2:02 a.m.)
> 
> 
> Review request for hive, Brock Noland and Szehon Ho.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Please see JIRA HIVE-7606 for description
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 5ac5a25 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSession.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManager.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java fcfcf42 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/spark/session/TestSparkSessionManagerImpl.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 0864dfb 
> 
> Diff: https://reviews.apache.org/r/24763/diff/
> 
> 
> Testing
> -------
> 
> Added unittests to test SessionManagerImpl in single session mode (HiveCLI) and multi-session mode (HiveServer2). Also tested few queries from Hive CLI. Testing using actual HiveServer2 is blocked due to HIVE-7747.
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>


--===============4926620368511903201==--