Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 92EC311008 for ; Wed, 13 Aug 2014 21:12:06 +0000 (UTC) Received: (qmail 17777 invoked by uid 500); 13 Aug 2014 21:12:06 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 17713 invoked by uid 500); 13 Aug 2014 21:12:06 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 17697 invoked by uid 99); 13 Aug 2014 21:12:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Aug 2014 21:12:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 683651D9DA9; Wed, 13 Aug 2014 21:12:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5141947254048781176==" MIME-Version: 1.0 Subject: Re: Review Request 24498: A method to extrapolate the missing column status for the partitions. From: "pengcheng xiong" To: "pengcheng xiong" , "hive" , "Sergey Shelukhin" Date: Wed, 13 Aug 2014 21:12:05 -0000 Message-ID: <20140813211205.1262.39259@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "pengcheng xiong" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/24498/ X-Sender: "pengcheng xiong" References: <20140813011035.1261.99299@reviews.apache.org> In-Reply-To: <20140813011035.1261.99299@reviews.apache.org> Reply-To: "pengcheng xiong" X-ReviewRequest-Repository: hive-git --===============5141947254048781176== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Aug. 13, 2014, 1:10 a.m., Sergey Shelukhin wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java, line 1101 > > > > > > please quote the identifier names (won't work on pgsql otherwise) and use parameters for parameters Sorry, could you please give an example of "use parameters for parameters"? Thanks! - pengcheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24498/#review50392 ----------------------------------------------------------- On Aug. 13, 2014, 8:54 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24498/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 8:54 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > We propose a method to extrapolate the missing column status for the partitions. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 767cffc > ql/src/test/queries/clientpositive/extrapolate_part_stats.q PRE-CREATION > ql/src/test/results/clientpositive/extrapolate_part_stats.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/24498/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > HIVE-7654.0.patch > https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch > > > Thanks, > > pengcheng xiong > > --===============5141947254048781176==--