Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 544AD104E7 for ; Tue, 5 Aug 2014 05:32:45 +0000 (UTC) Received: (qmail 1381 invoked by uid 500); 5 Aug 2014 05:32:45 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 1299 invoked by uid 500); 5 Aug 2014 05:32:44 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 1283 invoked by uid 99); 5 Aug 2014 05:32:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Aug 2014 05:32:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C44BB1D9F2A; Tue, 5 Aug 2014 05:32:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6055529276114323124==" MIME-Version: 1.0 Subject: Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs From: "Brock Noland" To: "Dong Chen" , "hive" , "Brock Noland" Date: Tue, 05 Aug 2014 05:32:30 -0000 Message-ID: <20140805053230.1586.36208@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brock Noland" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/24293/ X-Sender: "Brock Noland" References: <20140805034705.1586.42646@reviews.apache.org> In-Reply-To: <20140805034705.1586.42646@reviews.apache.org> Reply-To: "Brock Noland" X-ReviewRequest-Repository: hive-git --===============6055529276114323124== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/#review49563 ----------------------------------------------------------- This is awesome! I have two minor comments and I will let others do a more thorough review. service/src/java/org/apache/hive/service/cli/operation/Operation.java let's log the exception here service/src/java/org/apache/hive/service/cli/operation/Operation.java Let's log the exception here as well - Brock Noland On Aug. 5, 2014, 3:47 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24293/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 3:47 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-4629: HS2 should support an API to retrieve query logs > HiveServer2 should support an API to retrieve query logs. This is particularly relevant because HiveServer2 supports async execution but doesn't provide a way to report progress. Providing an API to retrieve query logs will help report progress to the client. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3bfc681 > service/if/TCLIService.thrift 80086b4 > service/src/gen/thrift/gen-cpp/TCLIService_types.h 1b37fb5 > service/src/gen/thrift/gen-cpp/TCLIService_types.cpp d5f98a8 > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TFetchResultsReq.java 808b73f > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TFetchType.java PRE-CREATION > service/src/gen/thrift/gen-py/TCLIService/ttypes.py 2cbbdd8 > service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 93f9a81 > service/src/java/org/apache/hive/service/cli/CLIService.java add37a1 > service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 87c10b9 > service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java f665146 > service/src/java/org/apache/hive/service/cli/FetchType.java PRE-CREATION > service/src/java/org/apache/hive/service/cli/ICLIService.java c569796 > service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java c9fd5f9 > service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java caf413d > service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java fd4e94d > service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java ebca996 > service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java 05991e0 > service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 315dbea > service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 0ec2543 > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java 3d3fddc > service/src/java/org/apache/hive/service/cli/operation/LogDivertAppender.java PRE-CREATION > service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java e0d17a1 > service/src/java/org/apache/hive/service/cli/operation/Operation.java 45fbd61 > service/src/java/org/apache/hive/service/cli/operation/OperationLog.java PRE-CREATION > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 21c33bc > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1 > service/src/java/org/apache/hive/service/cli/session/HiveSession.java 9785e95 > service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 4c3164e > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d > service/src/java/org/apache/hive/service/cli/session/SessionManager.java 816bea4 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 5c87bcb > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java e3384d3 > service/src/test/org/apache/hive/service/cli/operation/TestOperationLoggingAPI.java PRE-CREATION > > Diff: https://reviews.apache.org/r/24293/diff/ > > > Testing > ------- > > UT passed. > > > Thanks, > > Dong Chen > > --===============6055529276114323124==--