Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C3FCE11E02 for ; Mon, 4 Aug 2014 01:28:06 +0000 (UTC) Received: (qmail 64674 invoked by uid 500); 4 Aug 2014 01:28:06 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 64589 invoked by uid 500); 4 Aug 2014 01:28:06 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 64568 invoked by uid 99); 4 Aug 2014 01:28:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Aug 2014 01:28:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 435931C5EED; Mon, 4 Aug 2014 01:27:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0188626701583672371==" MIME-Version: 1.0 Subject: Re: Review Request 24211: HIVE-7554 - Parquet Hive should resolve column names in case insensitive manner From: "Brock Noland" To: "Szehon Ho" Cc: "hive" , "Brock Noland" Date: Mon, 04 Aug 2014 01:27:52 -0000 Message-ID: <20140804012752.1587.66647@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brock Noland" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/24211/ X-Sender: "Brock Noland" References: <20140803005609.8854.66993@reviews.apache.org> In-Reply-To: <20140803005609.8854.66993@reviews.apache.org> Reply-To: "Brock Noland" X-ReviewRequest-Repository: hive-git --===============0188626701583672371== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24211/ ----------------------------------------------------------- (Updated Aug. 4, 2014, 1:27 a.m.) Review request for hive and Szehon Ho. Bugs: HIVE-7554 https://issues.apache.org/jira/browse/HIVE-7554 Repository: hive-git Description ------- Resolves columns in a case insensitive manner. I also updated parquet_columnar.q as I was concerned about some code in resolveSchemaAccess. It does not appear to be a problem but I think the updated test covers more code. Diffs (updated) ----- data/files/parquet_mixed_case PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/DataWritableReadSupport.java c100dce ql/src/test/queries/clientpositive/parquet_columnar.q 4303d3e ql/src/test/queries/clientpositive/parquet_mixed_case.q PRE-CREATION ql/src/test/results/clientpositive/parquet_columnar.q.out 2222ff9 ql/src/test/results/clientpositive/parquet_mixed_case.q.out PRE-CREATION Diff: https://reviews.apache.org/r/24211/diff/ Testing ------- Thanks, Brock Noland --===============0188626701583672371==--