hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7921) Fix confusing dead assignment in return statement (JavaHiveVarcharObjectInspector)
Date Sat, 30 Aug 2014 19:38:53 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116535#comment-14116535
] 

Szehon Ho commented on HIVE-7921:
---------------------------------

I also doubt it, but we can always run locally to verify.  

The last 2 I've seen fail randomly (probably test order issue and should be looked at when
there's time); the first one I took a look and it's OOM, I filed HIVE-7924 to try to fix it.



> Fix confusing dead assignment in return statement (JavaHiveVarcharObjectInspector)
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-7921
>                 URL: https://issues.apache.org/jira/browse/HIVE-7921
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-7921.1.patch
>
>
> There are multiple instances of something like this {{return o = new HiveVarchar(value,
getMaxLength());}} in this class. That's not only confusing but also useless as it doesn't
do anything.
> I've removed those assignments and cleaned up the class a bit.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message