hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-7920) Fix issues with NotificationListener (finalize, overwriting of table properties, Checkstyle)
Date Sat, 30 Aug 2014 01:21:53 GMT

     [ https://issues.apache.org/jira/browse/HIVE-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lars Francke updated HIVE-7920:
-------------------------------

    Status: Patch Available  (was: Open)

> Fix issues with NotificationListener (finalize, overwriting of table properties, Checkstyle)
> --------------------------------------------------------------------------------------------
>
>                 Key: HIVE-7920
>                 URL: https://issues.apache.org/jira/browse/HIVE-7920
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-7920.1.patch
>
>
> This cleans up {{NotificationListener}}.
> * It was using a finalize method which is generally a bad idea and doesn't help here
as the class will be collected by GC anyway when the Metastore shuts down.
> * In {{onCreateTable}} it would unconditionally overwrite the property for the topic
name which could have been specified as part of the table creation
> * Adds detailed documentation to almost each method
> * Fixes Checkstyle issues like long lines and unnecessary protected access



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message