hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho (JIRA)" <>
Subject [jira] [Commented] (HIVE-7739) TestSparkCliDriver should not use includeQueryFiles
Date Fri, 15 Aug 2014 04:42:19 GMT


Szehon Ho commented on HIVE-7739:

Hey Brock, you can do the -Dqfile=... and even regex if it that test is included in spark.query.files.

I agree it might be useful to run non-enabled qfile test to see what happen (as what this
will allow), but I think its a more common use case to run a build locally against all enabled
spark test (say just to test everything, or if some explain plan change and we want to regenerate
all output files), which we cant do anymore with this patch right?  Thanks  

> TestSparkCliDriver should not use includeQueryFiles
> ---------------------------------------------------
>                 Key: HIVE-7739
>                 URL:
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: HIVE-7739.1-spark.patch
> By using includesQueryFile TestSparkCliDriver cannot be used by -Dqfile or -Dqfile_regex.
These options are very useful so let's remove it.
> spark.query.files in will still be used when run via the
pre-commit tests to generate -Dqfiles

This message was sent by Atlassian JIRA

View raw message