hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Na Yang (JIRA)" <>
Subject [jira] [Commented] (HIVE-7717) Add .q tests coverage for "union all" [Spark Branch]
Date Mon, 18 Aug 2014 23:29:18 GMT


Na Yang commented on HIVE-7717:

Hi Brock,

By looking at those test cases, most of them do not have "order by" following the "union all"
operator. For the test cases which pass this time might break  in another run. I think we
can hold this patch until the .q files are updated in trunk and merged to spark branch. Then
I will regenerate the output files from the new .q files with sort enabled. What do you think?


> Add .q tests coverage for "union all" [Spark Branch]
> ----------------------------------------------------
>                 Key: HIVE-7717
>                 URL:
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>    Affects Versions: spark-branch
>            Reporter: Na Yang
>            Assignee: Na Yang
>         Attachments: HIVE-7717.1-spark.patch, HIVE-7717.2-spark.patch
> Add automation test coverage for "union all", by searching through the q-tests in "ql/src/test/queries/clientpositive/"
for union tests (like union*.q) and verifying/enabling them on spark.
> Steps to do:
> 1.  Enable a qtest <q-test-name>.q in itests/src/test/resources/
by adding the .q test files to spark.query.files.
> 2.  Run mvn test -Dtest=TestSparkCliDriver -Dqfile=<q-test-name>.q -Dtest.output.overwrite=true
-Phadoop-2 to generate the output (located in ql/src/test/results/clientpositive/spark). 
File will be called <q-test-name>.q.out.
> 3.  Check the generated output is good by verifying the results.  For comparison, check
the MR version in ql/src/test/results/clientpositive/<q-test-name>.q.out.  The reason
its separate is because the explain plan outputs are different for Spark/MR.
> 4.  Checkin the modification to, and the generated q.out
file as well.  You only have to generate the output once.

This message was sent by Atlassian JIRA

View raw message