hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7600) ConstantPropagateProcFactory uses reference equality on Boolean
Date Thu, 07 Aug 2014 22:01:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089917#comment-14089917
] 

Hive QA commented on HIVE-7600:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12660342/HIVE-7600.patch

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 5885 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_dynpart_sort_opt_vectorization
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx
org.apache.hadoop.hive.ql.TestDDLWithRemoteMetastoreSecondNamenode.testCreateTableWithIndexAndPartitionsNonDefaultNameNode
org.apache.hive.jdbc.TestSSL.testSSLConnectionWithProperty
org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/214/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/214/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-214/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12660342

> ConstantPropagateProcFactory uses reference equality on Boolean
> ---------------------------------------------------------------
>
>                 Key: HIVE-7600
>                 URL: https://issues.apache.org/jira/browse/HIVE-7600
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ted Yu
>         Attachments: HIVE-7600.patch
>
>
> shortcutFunction() has the following code:
> {code}
>           if (c.getValue() == Boolean.FALSE) {
> {code}
> Boolean.FALSE.equals() should be used.
> There're a few other occurrences of using reference equality on Boolean in this class.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message