hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "KangHS (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-7600) ConstantPropagateProcFactory uses reference equality on Boolean
Date Thu, 07 Aug 2014 08:16:11 GMT

     [ https://issues.apache.org/jira/browse/HIVE-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

KangHS updated HIVE-7600:
-------------------------

    Attachment: HIVE-7600.patch

Change the compared method for Boolean's value.
- shortcutFunction()
- process()

> ConstantPropagateProcFactory uses reference equality on Boolean
> ---------------------------------------------------------------
>
>                 Key: HIVE-7600
>                 URL: https://issues.apache.org/jira/browse/HIVE-7600
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ted Yu
>         Attachments: HIVE-7600.patch
>
>
> shortcutFunction() has the following code:
> {code}
>           if (c.getValue() == Boolean.FALSE) {
> {code}
> Boolean.FALSE.equals() should be used.
> There're a few other occurrences of using reference equality on Boolean in this class.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message