hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7561) StarterProject: Move from assert to Guava Preconditions.* in Hive on Spark
Date Tue, 05 Aug 2014 00:43:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085578#comment-14085578
] 

Brock Noland commented on HIVE-7561:
------------------------------------

+1

> StarterProject: Move from assert to Guava Preconditions.* in Hive on Spark
> --------------------------------------------------------------------------
>
>                 Key: HIVE-7561
>                 URL: https://issues.apache.org/jira/browse/HIVE-7561
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>    Affects Versions: spark-branch
>            Reporter: Brock Noland
>            Assignee: Chao
>              Labels: StarterProject
>             Fix For: spark-branch
>
>         Attachments: HIVE-7561-spark.patch, HIVE-7561.2-spark.patch, HIVE-7561.3-spark.patch
>
>
> Hive uses the "assert" keyword all over the place. The problem is that assertions are
rarely enabled since they have to be specifically enabled. In the Spark code, e.g. GenSparkUtils,
let's use Preconditions.*.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message