hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7281) DbTxnManager acquiring wrong level of lock for dynamic partitioning
Date Tue, 19 Aug 2014 18:45:18 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102621#comment-14102621
] 

Ashutosh Chauhan commented on HIVE-7281:
----------------------------------------

Patch looks fine. 
But, I wonder if Entity type of DummyPartition make sense at all. It seems this entity is
created only in DP case to be used for locking and authorization purposes. And since in locking
case (as argued in this ticket) as well as auth case (probably) it make sense to use Table
entity. I dont see what useful purpose DummyPartition serves. On the contrary, it results
in confusion like the topic of this jira. Shall we just delete this DummyPartition entity.
cc: [~thejas]

> DbTxnManager acquiring wrong level of lock for dynamic partitioning
> -------------------------------------------------------------------
>
>                 Key: HIVE-7281
>                 URL: https://issues.apache.org/jira/browse/HIVE-7281
>             Project: Hive
>          Issue Type: Bug
>          Components: Locking, Transactions
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: HIVE-7281.patch
>
>
> Currently DbTxnManager.acquireLocks() locks the DUMMY_PARTITION for dynamic partitioning.
 But this is not adequate.  This will not prevent drop operations on partitions being written
to.  The lock should be at the table level.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message