hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke (JIRA)" <>
Subject [jira] [Commented] (HIVE-6123) Implement checkstyle in maven
Date Sun, 31 Aug 2014 00:03:53 GMT


Lars Francke commented on HIVE-6123:

* {{mvn checkstyle:checkstyle}} is a reporting goal, means it builds a HTML page in the respective
{{target/site}} folder.
* {{mvn checkstyle:checkstyle-aggregate generates one HTML report which combines all the submodule's
* {{mvn checkstyle:check}} is run as part of  the build and can fail it if needed. To actually
see any output use something like this: {{mvn checkstyle:check -Phadoop-2 -DskipTests -Dcheckstyle.consoleOutput=true}}

None of these run by default atm. The only one that really makes sense is the {{check}} goal.

This is an example invocation:
{{mvn compile checkstyle:check -Phadoop-2 -DskipTests -Dcheckstyle.consoleOutput=true -Dcheckstyle.violationSeverity=warning}}

We could think about something adding this to the build:
{{mvn compile checkstyle:check verify -Phadoop-2 -DskipTests -Dcheckstyle.consoleOutput=true}}
That'd show the warnings on each build but not fail it. Unfortunately there's now way to distinguish
between "grandfathered" and new code.

> Implement checkstyle in maven
> -----------------------------
>                 Key: HIVE-6123
>                 URL:
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Brock Noland
>            Assignee: Lars Francke
>         Attachments: HIVE-6123.1.patch, HIVE-6123.2.patch
> ant had a checkstyle target, we should do something similar for maven

This message was sent by Atlassian JIRA

View raw message