hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5799) session/operation timeout for hiveserver2
Date Mon, 25 Aug 2014 18:48:58 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14109489#comment-14109489
] 

Brock Noland commented on HIVE-5799:
------------------------------------

# It appears the constant SessionManager. SESSION_CHECK_INTERVAL is unused.
# HiveSessionImpl. opHandleSet should be converted to a synchronized set or a concurrent set
since it's now modified by the client thread and the background thread
# I think we should call OperationManager._getOperation  getOperationInternal as that seems
to be more standard for this use case in the Hive code base.
# Perhaps we should change OperationManager.closeExpiredOperations to not use closeOperation
but use similar code since it appears there is a harmless race condition there which will
log exceptions when the operation is closed during closeExpiredOperations

Does anyone else have any feedback? Otherwise once these are fixed I think we can commit.

> session/operation timeout for hiveserver2
> -----------------------------------------
>
>                 Key: HIVE-5799
>                 URL: https://issues.apache.org/jira/browse/HIVE-5799
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-5799.1.patch.txt, HIVE-5799.10.patch.txt, HIVE-5799.11.patch.txt,
HIVE-5799.12.patch.txt, HIVE-5799.12.patch.txt, HIVE-5799.2.patch.txt, HIVE-5799.3.patch.txt,
HIVE-5799.4.patch.txt, HIVE-5799.5.patch.txt, HIVE-5799.6.patch.txt, HIVE-5799.7.patch.txt,
HIVE-5799.8.patch.txt, HIVE-5799.9.patch.txt
>
>
> Need some timeout facility for preventing resource leakages from instable  or bad clients.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message