hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review requests & JIRA process
Date Thu, 07 Aug 2014 21:49:35 GMT
I think the process that works best for getting patches reviewed is adding
specific people to RB/JIRA and asking, usually the people who are active in
a related area of code. And nagging them until they either review or refuse
to review :)


On Thu, Aug 7, 2014 at 4:31 AM, Lars Francke <lars.francke@gmail.com> wrote:

> Hey,
>
> just wanted to bump this in case anyone has any opinions as well as what
> the procedure is for patches that don't get a review for a longer period of
> time. I'd like to avoid a lot of unnecessary work on my end :)
>
> Cheers,
> Lars
>
>
> On Wed, Aug 6, 2014 at 1:15 AM, Lars Francke <lars.francke@gmail.com>
> wrote:
>
> > Hi everyone,
> >
> > I have a couple of review requests that I'd love for someone to look at.
> > I'll list them below. I have however two more questions.
> >
> > Two of my issues are clean ups of existing code (HIVE-7622 & HIVE-7543).
> I
> > realize that they don't bring immediate benefit and I had planned to fix
> > some more of the issues Checkstyle, my IDE and SonarQube[1] complain
> about.
> > Is this okay for you guys or would you rather I stop this? I ask because
> > they take a significant amount of time not only for myself but also for a
> > reviewer and they go stale fast. I think it helps to have a clean
> codebase
> > for what it's worth.
> >
> > The second question is about the JIRA process: What's the best way to get
> > someone to review patches? I currently always create a review, attach the
> > patch to the Issue and set it to PATCH AVAILABLE. The documentation is
> not
> > quite clear about the process[2].
> >
> > These are the issues in need of reviews:
> >
> > * <https://issues.apache.org/jira/browse/HIVE-7622> (huge but I'd
> > appreciate an answer fast to avoid having to rebase it often)
> > * <https://issues.apache.org/jira/browse/HIVE-7543>
> > * <https://issues.apache.org/jira/browse/HIVE-6123>
> > * <https://issues.apache.org/jira/browse/HIVE-7107>
> >
> > Thanks!
> >
> > Cheers,
> > Lars
> >
> > [1] <http://www.sonarqube.org/> I have a publicly accessible server set
> > up with Hive analyzed, happy to send the link to anyone interested
> > http://i.imgur.com/e3KjR26.png
> >
> > [2] <
> >
> https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-MakingChanges
> > >
> >
>

-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message