hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables
Date Thu, 28 Aug 2014 07:56:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24472/#review51754
-----------------------------------------------------------



metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
<https://reviews.apache.org/r/24472/#comment90343>

    Why not just use Warehouse.getFileStatusesForSD(tbl.getSd())? It does the same thing.



metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
<https://reviews.apache.org/r/24472/#comment90349>

    If I undestand correctly, the difference between this method and the one below is FileStatus[].
If so factor out the common code and pass FileStatus[] as parameter. In case of tempTables
you can use WareHouse.getFileStatusesFromSD() API to get FileStatus[]. Correct me if I am
wrong.



ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
<https://reviews.apache.org/r/24472/#comment90353>

    You can reuse the oldCols, newCols List above instead of using iterator. idx in the for
loop is unused.



ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
<https://reviews.apache.org/r/24472/#comment90358>

    Is there any reason why you are not using FieldSchema's equals() here?



ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
<https://reviews.apache.org/r/24472/#comment90331>

    With my comment below (about using fully qualified column names in place of nested map),
this function should become substantially small.
    
    It will be like..
    ss.getTempTableColStats().get(fullyQualifiedColName)



ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
<https://reviews.apache.org/r/24472/#comment90334>

    Same can be done here as well. You can get the fully qualfied col name from colStats object
which can be used to update state.


- Prasanth_J


On Aug. 26, 2014, 6:37 p.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24472/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 6:37 p.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Bugs: HIVE-7649
>     https://issues.apache.org/jira/browse/HIVE-7649
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Update SessionHiveMetastoreClient to get column stats to work for temp tables.
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 5a56ced 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 37b1669

>   ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 24f3710

>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java fcfcf42 
>   ql/src/test/queries/clientnegative/temp_table_column_stats.q 9b7aa4a 
>   ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q PRE-CREATION

>   ql/src/test/results/clientnegative/temp_table_column_stats.q.out 4b0c0bc 
>   ql/src/test/results/clientpositive/temp_table_display_colstats_tbllvl.q.out PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/24472/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message