hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz" <le...@hortonworks.com>
Subject Re: Review Request 15449: session/operation timeout for hiveserver2
Date Thu, 28 Aug 2014 07:56:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15449/#review51760
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15449/#comment90359>

    Why did you remove the possible options?



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15449/#comment90357>

    Why did you remove the possible values?



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15449/#comment90356>

    Why did you remove the possible options?



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15449/#comment90354>

    Nit:  use camel caps on HiveServer2.



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15449/#comment90352>

    Please restore "(in seconds)" to description and specify other time units that can be
used, if any.



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15449/#comment90350>

    Please restore "(in seconds)" to description and specify other time units that can be
used, if any.



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15449/#comment90337>

    Please add time unit information:  "Accepts time units like d/h/m/s/ms/us/ns."



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15449/#comment90338>

    Please add time unit information:  "Accepts time units like d/h/m/s/ms/us/ns."



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15449/#comment90339>

    Please add time unit information:  "Accepts time units like d/h/m/s/ms/us/ns."


- Lefty Leverenz


On Aug. 28, 2014, 2:31 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15449/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 2:31 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5799
>     https://issues.apache.org/jira/browse/HIVE-5799
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Need some timeout facility for preventing resource leakages from instable or bad clients.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/ant/GenHiveTemplate.java 4293b7c 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 74bb863 
>   common/src/java/org/apache/hadoop/hive/conf/Validator.java cea9c41 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2SessionTimeout.java
PRE-CREATION 
>   service/src/java/org/apache/hive/service/cli/CLIService.java ff5de4a 
>   service/src/java/org/apache/hive/service/cli/OperationState.java 3e15f0c 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 0d6436e 
>   service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 2867301

>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 270e4a6 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 84e1c7e 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 4e5f595 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 39d2184

>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 17c1c7b 
>   service/src/test/org/apache/hive/service/cli/CLIServiceTest.java d01e819 
> 
> Diff: https://reviews.apache.org/r/15449/diff/
> 
> 
> Testing
> -------
> 
> Confirmed in the local environment.
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message