hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere" <jd...@hortonworks.com>
Subject Re: Review Request 25125: HIVE-7895 : Storage based authorization should consider sticky bit for drop actions
Date Thu, 28 Aug 2014 05:13:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25125/#review51727
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java
<https://reviews.apache.org/r/25125/#comment90299>

    Is it necessary to check the delete privs on the parent dir for external tables, given
that the table directory is not actually deleted for external tables?



ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java
<https://reviews.apache.org/r/25125/#comment90283>

    Consider moving some of this functionality to FileUtils as a utility function. I can think
of a couple of places that could use this, HMSHandler.drop_database_core() and SessionHiveMetaStoreClient.dropTempTable()
both call Warehouse.isWritable(), but this functionality in this method may be more appropriate.


- Jason Dere


On Aug. 27, 2014, 10:30 p.m., Thejas Nair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25125/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 10:30 p.m.)
> 
> 
> Review request for hive, Jason Dere and Sushanth Sowmyan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-7895
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationDrops.java
PRE-CREATION 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationProvider.java
b447204 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java
ddbe30c 
> 
> Diff: https://reviews.apache.org/r/25125/diff/
> 
> 
> Testing
> -------
> 
> New tests included.
> 
> 
> Thanks,
> 
> Thejas Nair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message