hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vaibhav Gumashta" <vgumas...@hortonworks.com>
Subject Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager
Date Tue, 26 Aug 2014 21:53:26 GMT


> On Aug. 26, 2014, 6:17 p.m., Szehon Ho wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 5229
> > <https://reviews.apache.org/r/23320/diff/5/?file=669421#file669421line5229>
> >
> >     Can we remove these whitespace change from the patch?  I guess its good to cleanup,
but I'm not 100% sure if they are all right.  Some place like here the indent is gone, elsewhere
they are added, etc..
> >     
> >     Also maybe we can remove Hive.java cleanup from this patch as well?

Sorry about this. Editor settings were adding the cleanup.


- Vaibhav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review51558
-----------------------------------------------------------


On Aug. 26, 2014, 5:10 p.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 5:10 p.m.)
> 
> 
> Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
> 
> 
> Bugs: HIVE-7353
>     https://issues.apache.org/jira/browse/HIVE-7353
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-7353
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f4afd9 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 06d7595 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 0693039 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e387b8f 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java bc9254c 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 9798cf3 
>   service/src/java/org/apache/hive/service/cli/CLIService.java d2cdfc1 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java bc0a02c 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java d573592 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 37b05fc

>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java c380b69

>   service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java
PRE-CREATION 
>   service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION

>   service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java
66fc1fc 
> 
> Diff: https://reviews.apache.org/r/23320/diff/
> 
> 
> Testing
> -------
> 
> Manual testing using Yourkit.
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message