hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Review Request 25037: HIVE-7846 - authorization api should support group, not assume case insensitive role names
Date Mon, 25 Aug 2014 21:04:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25037/
-----------------------------------------------------------

Review request for hive and Jason Dere.


Bugs: HIVE-7846
    https://issues.apache.org/jira/browse/HIVE-7846


Repository: hive-git


Description
-------

See https://issues.apache.org/jira/browse/HIVE-7846


Diffs
-----

  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessControllerForTest.java
89429b6 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java
1d039ad 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactoryForTest.java
0f41a8f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java
f92ecf2 
  ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java 8413fb7 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java 2113f45

  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrincipal.java 30a4496

  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java
a6b008a 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessControllerWrapper.java
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java
9ceac0c 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java
9db3d74 
  ql/src/test/queries/clientnegative/authorization_grant_group.q PRE-CREATION 
  ql/src/test/queries/clientnegative/authorization_public_create.q 002389f 
  ql/src/test/queries/clientnegative/authorization_public_drop.q 69c5a8d 
  ql/src/test/queries/clientnegative/authorization_role_case.q PRE-CREATION 
  ql/src/test/queries/clientnegative/authorize_grant_public.q bfd3165 
  ql/src/test/queries/clientnegative/authorize_revoke_public.q 2b29822 
  ql/src/test/queries/clientpositive/authorization_1.q 25c9918 
  ql/src/test/queries/clientpositive/authorization_5.q 8869edc 
  ql/src/test/queries/clientpositive/authorization_grant_public_role.q fe177ac 
  ql/src/test/queries/clientpositive/authorization_role_grant2.q 95fa4e6 
  ql/src/test/results/clientnegative/authorization_grant_group.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/authorization_public_create.q.out 4c9a2ad 
  ql/src/test/results/clientnegative/authorization_public_drop.q.out 520b56e 
  ql/src/test/results/clientnegative/authorization_role_case.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/authorize_grant_public.q.out ef4a1b1 
  ql/src/test/results/clientnegative/authorize_revoke_public.q.out 618fedd 
  ql/src/test/results/clientpositive/authorization_1.q.out dac0820 
  ql/src/test/results/clientpositive/authorization_5.q.out 6e5187e 
  ql/src/test/results/clientpositive/authorization_grant_public_role.q.out 17b6c8a 
  ql/src/test/results/clientpositive/authorization_role_grant2.q.out 56e7667 

Diff: https://reviews.apache.org/r/25037/diff/


Testing
-------

Tests of old default authorization mode modified to verify that roles with mixed case now
work.
Added -ve test for group in grant with sql std auth.


Thanks,

Thejas Nair


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message