hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 24830: HIVE-7548: Precondition checks should not fail the merge task in case of automatic trigger
Date Mon, 25 Aug 2014 19:54:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24830/
-----------------------------------------------------------

(Updated Aug. 25, 2014, 7:54 p.m.)


Review request for hive and Gunther Hagleitner.


Bugs: HIVE-7548
    https://issues.apache.org/jira/browse/HIVE-7548


Repository: hive-git


Description
-------

ORC fast merge (HIVE-7509) will fail the merge task in case if any of the precondition checks
fail. Precondition check fail is good for "ALTER TABLE .. CONCATENATE" but not for automatic
trigger of merge task from conditional resolver. In case if a partition has non-compatible
ORC files for merging then the merge task should ignore it and not fail the task.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1d6a93a 
  ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeMapper.java beb4f7d 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileMergeMapper.java b36152a 
  ql/src/test/queries/clientnegative/orc_merge1.q b2d42cd 
  ql/src/test/queries/clientnegative/orc_merge2.q 2f62ee7 
  ql/src/test/queries/clientnegative/orc_merge3.q 5158e2e 
  ql/src/test/queries/clientnegative/orc_merge4.q ad48572 
  ql/src/test/queries/clientnegative/orc_merge5.q e94a8cc 
  ql/src/test/queries/clientpositive/orc_merge_incompat1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/orc_merge_incompat2.q PRE-CREATION 
  ql/src/test/results/clientpositive/orc_merge_incompat1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/orc_merge_incompat2.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/24830/diff/


Testing
-------


Thanks,

Prasanth_J


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message