hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 24918: HIVE-7791 - Enable tests on Spark branch (1) [Sparch Branch]
Date Fri, 22 Aug 2014 23:28:10 GMT


> On Aug. 21, 2014, 5:29 p.m., Szehon Ho wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java, line 195
> > <https://reviews.apache.org/r/24918/diff/1/?file=665809#file665809line195>
> >
> >     I'm just curious, was this to fix a test?
> >     
> >     Also is it necessary to catch and wrap in RuntimeException here?
> 
> Brock Noland wrote:
>     Good point. In the next rev I will wrap, but with a better exception and error message.

And yes this was to fix bucketed tables.


- Brock


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24918/#review51187
-----------------------------------------------------------


On Aug. 21, 2014, 12:26 a.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24918/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 12:26 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Enable tests
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties ecb8b74 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java d16f1be 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java dc621cf 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java 026f4e0 
>   ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/alter_merge_stats_orc.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/bucket2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/bucket3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/bucket4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/count.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/create_merge_compressed.q.out PRE-CREATION

>   ql/src/test/results/clientpositive/spark/ctas.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/custom_input_output_format.q.out PRE-CREATION

>   ql/src/test/results/clientpositive/spark/disable_merge_for_bucketing.q.out PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/24918/diff/
> 
> 
> Testing
> -------
> 
> Verified output vs MR
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message