hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 24918: HIVE-7791 - Enable tests on Spark branch (1) [Sparch Branch]
Date Thu, 21 Aug 2014 17:29:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24918/#review51187
-----------------------------------------------------------


Hey Brock, thanks, just some pretty minor comments below.


ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java
<https://reviews.apache.org/r/24918/#comment89218>

    I'm just curious, was this to fix a test?
    
    Also is it necessary to catch and wrap in RuntimeException here?



ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java
<https://reviews.apache.org/r/24918/#comment89216>

    This is a bit strange, as the resolve() method returns null.  Not sure if we should assign
to a variable as of now?


- Szehon Ho


On Aug. 21, 2014, 12:26 a.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24918/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 12:26 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Enable tests
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties ecb8b74 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java d16f1be 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java dc621cf 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java 026f4e0 
>   ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/alter_merge_stats_orc.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/bucket2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/bucket3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/bucket4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/count.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/create_merge_compressed.q.out PRE-CREATION

>   ql/src/test/results/clientpositive/spark/ctas.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/spark/custom_input_output_format.q.out PRE-CREATION

>   ql/src/test/results/clientpositive/spark/disable_merge_for_bucketing.q.out PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/24918/diff/
> 
> 
> Testing
> -------
> 
> Verified output vs MR
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message