hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs
Date Tue, 19 Aug 2014 16:05:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24293/#review50977
-----------------------------------------------------------


Hi,

This patch looks really good! I was not clear when I said how we should define the new fetchResults
method. I hope my response below is clear, if not, please let me know!


service/src/java/org/apache/hive/service/cli/CLIServiceClient.java
<https://reviews.apache.org/r/24293/#comment88863>

    Thank you very much for removing the thrift enum! That resolves the thrift enum compatability
issue!
    
    I should have been a more clear on the other issue I was describing. I have felt for some
time we should change the way we do RPC in Hive. Today we define specific methods for the
use case at hand. This causes method explosion. For example after this patch we would have
three method signatures which fetch results.
    
    Going forward I think we should define methods differently. For example, for this method
I think we should define the classes:
    
    FetchResultsRequest and FetchResultsResponse
    
    and then have a new method:
    
    FetchResultsResponse fetchResults(FetchResultsRequest request) throws HiveSQLException

    
    and then all of the arguments can be defined inside FetchResultsRequest. That way everytime
we add an argument, we don't to define a new public RPC method. I have described this approach
on this mail here:
    
    http://mail-archives.apache.org/mod_mbox/hive-dev/201403.mbox/%3CCAFukC=6XsS1KjgAD7HV2V4wWoiGjzctm1RuJCCzSOCDJ8X31eg@mail.gmail.com%3E


- Brock Noland


On Aug. 14, 2014, 3:09 p.m., Dong Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24293/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 3:09 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-4629: HS2 should support an API to retrieve query logs
> HiveServer2 should support an API to retrieve query logs. This is particularly relevant
because HiveServer2 supports async execution but doesn't provide a way to report progress.
Providing an API to retrieve query logs will help report progress to the client.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3bfc681 
>   service/if/TCLIService.thrift 80086b4 
>   service/src/gen/thrift/gen-cpp/TCLIService_types.h 1b37fb5 
>   service/src/gen/thrift/gen-cpp/TCLIService_types.cpp d5f98a8 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TFetchResultsReq.java
808b73f 
>   service/src/gen/thrift/gen-py/TCLIService/ttypes.py 2cbbdd8 
>   service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 93f9a81 
>   service/src/java/org/apache/hive/service/cli/CLIService.java add37a1 
>   service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 87c10b9 
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java f665146

>   service/src/java/org/apache/hive/service/cli/FetchType.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/cli/ICLIService.java c569796 
>   service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java c9fd5f9

>   service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java caf413d

>   service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java fd4e94d

>   service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java ebca996

>   service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
05991e0 
>   service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 315dbea

>   service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 0ec2543

>   service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java 3d3fddc

>   service/src/java/org/apache/hive/service/cli/operation/LogDivertAppender.java PRE-CREATION

>   service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java e0d17a1

>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 45fbd61 
>   service/src/java/org/apache/hive/service/cli/operation/OperationLog.java PRE-CREATION

>   service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 21c33bc

>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1 
>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 9785e95 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 4c3164e 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 816bea4 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 5c87bcb 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java e3384d3

>   service/src/test/org/apache/hive/service/cli/operation/TestOperationLoggingAPI.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24293/diff/
> 
> 
> Testing
> -------
> 
> UT passed.
> 
> 
> Thanks,
> 
> Dong Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message