hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gopal V" <go...@hortonworks.com>
Subject Re: Review Request 24834: HIVE-7771: ORC PPD fails for some decimal predicates
Date Tue, 19 Aug 2014 01:57:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24834/#review50950
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java
<https://reviews.apache.org/r/24834/#comment88843>

    Does this imply an immediate return?
    
    Is there are reason we go through the type coercion codepaths after getting the value
out of the object?


- Gopal V


On Aug. 19, 2014, 1:32 a.m., Prasanth_J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24834/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 1:32 a.m.)
> 
> 
> Review request for hive, Gopal V and Gunther Hagleitner.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Some queries like 
> {code}
> select * from table where dcol<=11.22BD;
> {code}
> fails when ORC predicate pushdown is enabled.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb 
>   ql/src/test/queries/clientpositive/orc_ppd_decimal.q a93590e 
>   ql/src/test/results/clientpositive/orc_ppd_decimal.q.out 0c11ea8 
> 
> Diff: https://reviews.apache.org/r/24834/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasanth_J
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message