hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 24762: HIVE-7746: Spark: Cleanup SparkClient and make refreshLocalResources method synchronized.
Date Sun, 17 Aug 2014 21:04:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24762/#review50845
-----------------------------------------------------------


Nice work! This is a much needed cleanup. Just one minor thought below about handing of the
strings.


ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java
<https://reviews.apache.org/r/24762/#comment88708>

    Should we use Guava splitter here?
    
    private static final Splitter CSV_SPLITTER = Splliter.on(",").omitEmpty();
    
    then we can:
    
    for x in CSV_SPLITTER.split(Strings.nulltoEmpty(x))
    
    without any additional checks?



ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java
<https://reviews.apache.org/r/24762/#comment88709>

    same guava stmt as above


- Brock Noland


On Aug. 16, 2014, 1:36 a.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24762/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2014, 1:36 a.m.)
> 
> 
> Review request for hive, Brock Noland and Szehon Ho.
> 
> 
> Bugs: HIVE-7746
>     https://issues.apache.org/jira/browse/HIVE-7746
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Minor cleanup and thread safe refreshLocalResource needed for HIVE-7606.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java bfb34ec 
> 
> Diff: https://reviews.apache.org/r/24762/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message