hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergio Pena" <sergio.p...@cloudera.com>
Subject Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for decimal numbers
Date Fri, 15 Aug 2014 18:01:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/
-----------------------------------------------------------

(Updated Aug. 15, 2014, 6:01 p.m.)


Review request for hive.


Bugs: HIVE-7373
    https://issues.apache.org/jira/browse/HIVE-7373


Repository: hive-git


Description
-------

Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods. 
This change affects the Decimal128 getHiveDecimalString() method; so a new 'actualScale' variable
is used that stores the actual scale of a value passed to Decimal128.

The rest of the changes are added to fix decimal query tests to match the new HiveDecimal
value.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d 
  common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015 
  common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 46236a5 
  common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 1384a45 
  data/files/kv10.txt PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 2a871c5

  ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 4c5b3a5 
  ql/src/test/queries/clientpositive/decimal_trailing.q PRE-CREATION 
  ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc 
  ql/src/test/results/clientpositive/avro_decimal.q.out 1868de3 
  ql/src/test/results/clientpositive/avro_decimal_native.q.out bc87a7d 
  ql/src/test/results/clientpositive/char_pad_convert.q.out 1f81426 
  ql/src/test/results/clientpositive/decimal_2.q.out 794bad0 
  ql/src/test/results/clientpositive/decimal_3.q.out 524fa62 
  ql/src/test/results/clientpositive/decimal_4.q.out 7444e83 
  ql/src/test/results/clientpositive/decimal_5.q.out 52dae22 
  ql/src/test/results/clientpositive/decimal_6.q.out 4338b52 
  ql/src/test/results/clientpositive/decimal_precision.q.out ea08b73 
  ql/src/test/results/clientpositive/decimal_trailing.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/decimal_udf.q.out 02a0caa 
  ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a 
  ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 890cb2c 
  ql/src/test/results/clientpositive/parquet_decimal.q.out b2d542f 
  ql/src/test/results/clientpositive/parquet_decimal1.q.out 9ff0950 
  ql/src/test/results/clientpositive/serde_regex.q.out e231a09 
  ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out 9abaa46 
  ql/src/test/results/clientpositive/tez/vector_data_types.q.out 4954825 
  ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 437e830 
  ql/src/test/results/clientpositive/udf_case.q.out 6c186bd 
  ql/src/test/results/clientpositive/udf_when.q.out cbb1210 
  ql/src/test/results/clientpositive/vector_between_in.q.out bbd23d2 
  ql/src/test/results/clientpositive/vector_data_types.q.out 007f4e8 
  ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552 
  ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732 
  ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e 
  ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 3327c90 
  ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out d60d855 
  ql/src/test/results/clientpositive/windowing_decimal.q.out 88d11af 
  ql/src/test/results/clientpositive/windowing_navfn.q.out 95d7942 
  ql/src/test/results/clientpositive/windowing_rank.q.out 9976fdb 
  serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d


Diff: https://reviews.apache.org/r/24467/diff/


Testing
-------


Thanks,

Sergio Pena


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message