hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Review Request 24711: HIVE-7734: Join stats annotation rule is not updating columns statistics correctly
Date Thu, 14 Aug 2014 20:07:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24711/
-----------------------------------------------------------

Review request for hive, Gunther Hagleitner and Harish Butani.


Bugs: HIVE-7734
    https://issues.apache.org/jira/browse/HIVE-7734


Repository: hive-git


Description
-------

HIVE-7679 is not doing the correct thing. The scale down/up factor updating column stats was
wrong as ratio = newRowCount/oldRowCount is always infinite (oldRowCount = 0). The old row
count should be retrieved from parent corresponding to the current column whose statistics
is being updated.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
838d6b1 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 99b26bd 
  ql/src/test/results/clientpositive/union20.q.out 663d128 

Diff: https://reviews.apache.org/r/24711/diff/


Testing
-------


Thanks,

Prasanth_J


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message