hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin" <ser...@hortonworks.com>
Subject Re: Review Request 24498: A method to extrapolate the missing column status for the partitions.
Date Wed, 13 Aug 2014 01:10:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/#review50392
-----------------------------------------------------------


There's no JDO path at all. Is this intended?


metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment88164>

    whitespace here and further on



metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment88165>

    this common part of the query could be moved to constant



metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment88166>

    please quote the identifier names (won't work on pgsql otherwise) and use parameters for
parameters



metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment88167>

    I wonder if so much logic belongs to DirectSQL class; it is growing pretty big. Maybe
it can be moved out


- Sergey Shelukhin


On Aug. 12, 2014, 5:57 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24498/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 5:57 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> We propose a method to extrapolate the missing column status for the partitions.
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 43c412d

> 
> Diff: https://reviews.apache.org/r/24498/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> HIVE-7654.0.patch
>   https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message