hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz" <leftylever...@gmail.com>
Subject Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager
Date Tue, 12 Aug 2014 17:29:41 GMT


> On Aug. 6, 2014, 7:24 p.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1457
> > <https://reviews.apache.org/r/23320/diff/2/?file=653813#file653813line1457>
> >
> >     Please specify time units.
> >     
> >     Also, what does #min mean here -- minimum?  (If so, is it set by some other
parameter?)
> >     
> >     Since this is keepalive.time, at first I thought #min meant minutes but that
makes no sense at all.

Thanks, good fix.


> On Aug. 6, 2014, 7:24 p.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1482
> > <https://reviews.apache.org/r/23320/diff/2/?file=653813#file653813line1482>
> >
> >     Please specify time units.
> >     
> >     Also, what does #min mean and is it set by some other parameter?

Thanks again.


- Lefty


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review49792
-----------------------------------------------------------


On Aug. 12, 2014, 11:33 a.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 11:33 a.m.)
> 
> 
> Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
> 
> 
> Bugs: HIVE-7353
>     https://issues.apache.org/jira/browse/HIVE-7353
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-7353
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ff282c5 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 760777a 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88

>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5

>   service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java
PRE-CREATION 
>   service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/23320/diff/
> 
> 
> Testing
> -------
> 
> Manual testing using Yourkit.
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message