hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis Ryu" <navis....@nexr.com>
Subject Re: Review Request 24137: allow disabling direct sql per query with external metastore
Date Mon, 11 Aug 2014 07:37:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24137/
-----------------------------------------------------------

(Updated Aug. 11, 2014, 7:37 a.m.)


Review request for hive.


Changes
-------

added getMetaConf(), which shows current value of the meta variable.


Bugs: HIVE-7532
    https://issues.apache.org/jira/browse/HIVE-7532


Repository: hive-git


Description
-------

Currently with external metastore, direct sql can only be disabled via metastore config globally.
Perhaps it makes sense to have the ability to propagate the setting per query from client
to override the metastore setting, e.g. if one particular query causes it to fail.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558 
  common/src/java/org/apache/hadoop/hive/conf/SystemVariables.java ee98d17 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
9e416b5 
  metastore/if/hive_metastore.thrift 9e93b95 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6e689d0 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 85a77d9 
  metastore/src/java/org/apache/hadoop/hive/metastore/IHMSHandler.java 1675751 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 8746c37 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java c28c46a

  metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java 86172b9 
  metastore/src/java/org/apache/hadoop/hive/metastore/events/ConfigChangeEvent.java PRE-CREATION

  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 39b032e 
  ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 2baa24a 
  ql/src/test/queries/clientpositive/set_metaconf.q PRE-CREATION 
  ql/src/test/results/clientpositive/set_metaconf.q.out PRE-CREATION 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 4c3164e 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495 

Diff: https://reviews.apache.org/r/24137/diff/


Testing
-------


Thanks,

Navis Ryu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message