hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 24445: HIVE-7642, Set hive input format by configuration.
Date Mon, 11 Aug 2014 04:47:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24445/#review50144
-----------------------------------------------------------


Hi,

Thank you very much for taking this on! I have one question below.


ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java
<https://reviews.apache.org/r/24445/#comment87742>

    If the configuration is incorrect, perhaps we should throw an error? Meaning re-throw
the exception?


- Brock Noland


On Aug. 7, 2014, 7:30 a.m., chengxiang li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24445/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 7:30 a.m.)
> 
> 
> Review request for hive, Brock Noland and Szehon Ho.
> 
> 
> Bugs: HIVE-7642
>     https://issues.apache.org/jira/browse/HIVE-7642
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Currently hive input format is hard coded as HiveInputFormat, we should set this parameter
from configuration.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 45eff67 
> 
> Diff: https://reviews.apache.org/r/24445/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> chengxiang li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message