hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz" <leftylever...@gmail.com>
Subject Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics
Date Fri, 08 Aug 2014 01:23:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24427/#review49999
-----------------------------------------------------------


HiveConf.java parameter descriptions look good.  I just mentioned two nano-nits to prove I'd
done the review.


common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/24427/#comment87464>

    utterly ignorable nitpick:  leading space isn't necessary (" of the number of keys ...)



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/24427/#comment87465>

    even more ignorable:  trailing space isn't necessary ("Initial capacity of ")


- Lefty Leverenz


On Aug. 7, 2014, 11:53 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24427/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 11:53 p.m.)
> 
> 
> Review request for hive, Gunther Hagleitner, Mostafa Mokhtar, and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java cf64aa0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMultiHashMap.java
cdb5dc5 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HashMapWrapper.java 5b3b770

>   ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java
629457c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HashTableLoader.java 6d292d0 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java d42e1f7 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java 29d895a

>   ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java 44cb9c0 
> 
> Diff: https://reviews.apache.org/r/24427/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message