hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dong Chen" <dong1.c...@intel.com>
Subject Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs
Date Thu, 07 Aug 2014 16:09:06 GMT


> On Aug. 5, 2014, 8:56 a.m., Lars Francke wrote:
> > service/src/java/org/apache/hive/service/cli/operation/LogDivertAppender.java, line
81
> > <https://reviews.apache.org/r/24293/diff/1/?file=651562#file651562line81>
> >
> >     I don't understand how log data ends up in the writer? I looked for accesses
of it but it doesn't seem to be touched at all. What am I missing?
> >     
> >     Also for a little boost if the code stays like this you can move it after the
null check to avoid string conversion if the OperationLog is null

This LogDivertAppender inherits from WriterAppender, and when its method subAppend(event)
is invoked, the first line super.subAppend(event) will write the log into writer.
Not matter the OperationLog is null or not, the writer should be reset, since the log in it
will be not used any more in this Appender. Otherwise, the remaining log in writer might mix
with next log.
So maybe we could keep the access and null check order. :)


- Dong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24293/#review49573
-----------------------------------------------------------


On Aug. 5, 2014, 3:47 a.m., Dong Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24293/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 3:47 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-4629: HS2 should support an API to retrieve query logs
> HiveServer2 should support an API to retrieve query logs. This is particularly relevant
because HiveServer2 supports async execution but doesn't provide a way to report progress.
Providing an API to retrieve query logs will help report progress to the client.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3bfc681 
>   service/if/TCLIService.thrift 80086b4 
>   service/src/gen/thrift/gen-cpp/TCLIService_types.h 1b37fb5 
>   service/src/gen/thrift/gen-cpp/TCLIService_types.cpp d5f98a8 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TFetchResultsReq.java
808b73f 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TFetchType.java
PRE-CREATION 
>   service/src/gen/thrift/gen-py/TCLIService/ttypes.py 2cbbdd8 
>   service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 93f9a81 
>   service/src/java/org/apache/hive/service/cli/CLIService.java add37a1 
>   service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 87c10b9 
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java f665146

>   service/src/java/org/apache/hive/service/cli/FetchType.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/cli/ICLIService.java c569796 
>   service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java c9fd5f9

>   service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java caf413d

>   service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java fd4e94d

>   service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java ebca996

>   service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
05991e0 
>   service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 315dbea

>   service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 0ec2543

>   service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java 3d3fddc

>   service/src/java/org/apache/hive/service/cli/operation/LogDivertAppender.java PRE-CREATION

>   service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java e0d17a1

>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 45fbd61 
>   service/src/java/org/apache/hive/service/cli/operation/OperationLog.java PRE-CREATION

>   service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 21c33bc

>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1 
>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 9785e95 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 4c3164e 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 816bea4 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 5c87bcb 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java e3384d3

>   service/src/test/org/apache/hive/service/cli/operation/TestOperationLoggingAPI.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24293/diff/
> 
> 
> Testing
> -------
> 
> UT passed.
> 
> 
> Thanks,
> 
> Dong Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message