hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chaoyu Tang" <ctang...@gmail.com>
Subject Review Request 24404: HIVE-7635: Query having same aggregate functions but different case throws IndexOutOfBoundsException
Date Wed, 06 Aug 2014 19:04:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24404/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-7635
    https://issues.apache.org/jira/browse/HIVE-7635


Repository: hive-git


Description
-------

A query having same aggregate functions but in different case (e.g. SELECT key, COUNT(value)
FROM src GROUP BY key HAVING count(value) >= 4) does not work and throws IndexOutOfBoundsException.
The cause is that Hive treats count(value) and COUNT(value) in this query as two different
aggregate expression when compiling query and generating plan. They are case sensitive.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 51838ae 
  ql/src/test/queries/clientpositive/having.q 5b1aa69 
  ql/src/test/results/clientpositive/having.q.out d912001 

Diff: https://reviews.apache.org/r/24404/diff/


Testing
-------

1. The fix addressed the failed query with different case in aggregate function name in the
query
2. New unit tests passed
3. patch will be submitted for pre-commit tests


Thanks,

Chaoyu Tang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message