hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chao Sun" <chao....@cloudera.com>
Subject Re: Review Request 24352: StarterProject: Fix exception handling in POC code
Date Wed, 06 Aug 2014 04:53:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24352/
-----------------------------------------------------------

(Updated Aug. 6, 2014, 4:53 a.m.)


Review request for hive and Brock Noland.


Changes
-------

Hi Brock,

Thanks for the comments! I've addressed these issues and updated the patch. Please take a
look.


Bugs: HIVE-7560
    https://issues.apache.org/jira/browse/HIVE-7560


Repository: hive-git


Description
-------

The POC code just printed exceptions to stderr. We should either:
1) LOG at INFO/WARN/ERROR
2) Or rethrow (perhaps wrapped in runtime exception) anything is a fatal error


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java 20a1938 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java 358cbc7 

Diff: https://reviews.apache.org/r/24352/diff/


Testing
-------


Thanks,

Chao Sun


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message