hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 24352: StarterProject: Fix exception handling in POC code
Date Wed, 06 Aug 2014 03:23:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24352/#review49689
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java
<https://reviews.apache.org/r/24352/#comment86971>

    we should re-throw in runtime exception



ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java
<https://reviews.apache.org/r/24352/#comment86970>

    I don't think we should return null, we should wrap in runtime exception with a error
message describing the issue and wrapping the exception.



ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java
<https://reviews.apache.org/r/24352/#comment86973>

    pls add e.getMessage() to the error message



ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java
<https://reviews.apache.org/r/24352/#comment86972>

    pls add e.getMessage() to the error message


- Brock Noland


On Aug. 5, 2014, 10:32 p.m., Chao Sun wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24352/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 10:32 p.m.)
> 
> 
> Review request for hive and Brock Noland.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> The POC code just printed exceptions to stderr. We should either:
> 1) LOG at INFO/WARN/ERROR
> 2) Or rethrow (perhaps wrapped in runtime exception) anything is a fatal error
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java 20a1938 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java 358cbc7 
> 
> Diff: https://reviews.apache.org/r/24352/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chao Sun
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message