hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chao Sun" <>
Subject Re: Review Request 24195: StarterProject: Move from assert to Guava Preconditions.* in Hive on Spark
Date Mon, 04 Aug 2014 21:50:25 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 4, 2014, 9:50 p.m.)

Review request for hive.


Hi Brock,

Thanks for the suggestions! I've updated the diff. Please have a look. :)

Bugs: HIVE-7561

Repository: hive-git


Hive uses the "assert" keyword all over the place. The problem is that assertions are rarely
enabled since they have to be specifically enabled. In the Spark code, e.g. GenSparkUtils,
let's use Preconditions.*.

Diffs (updated)

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/ 8c58333

  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/ 25eea14 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/ ceb7b6c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/ 3a0f4c9

  ql/src/java/org/apache/hadoop/hive/ql/plan/ 86d14f1 




Chao Sun

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message