hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 24195: StarterProject: Move from assert to Guava Preconditions.* in Hive on Spark
Date Mon, 04 Aug 2014 21:18:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24195/#review49489
-----------------------------------------------------------


Thank you very much Chao! I have a few minor nits and then I will commit.


ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java
<https://reviews.apache.org/r/24195/#comment86557>

    Instead of calling context.childToWorkMap.get(parentRS).size() twice, lets:
    
    int workMapSize = context.childToWorkMap.get(parentRS).size();
    ....



ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkWork.java
<https://reviews.apache.org/r/24195/#comment86558>

    While you are here, can you remove this trailing space?



ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkProcessAnalyzeTable.java
<https://reviews.apache.org/r/24195/#comment86559>

    I know it's not related, but can you remove this trailing ws as well?



ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkProcessAnalyzeTable.java
<https://reviews.apache.org/r/24195/#comment86560>

    Let's add the count to this message.


- Brock Noland


On Aug. 1, 2014, 11:45 p.m., Chao Sun wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24195/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 11:45 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7561
>     https://issues.apache.org/jira/browse/HIVE-7561
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Hive uses the "assert" keyword all over the place. The problem is that assertions are
rarely enabled since they have to be specifically enabled. In the Spark code, e.g. GenSparkUtils,
let's use Preconditions.*.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java
8c58333 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkUtils.java 25eea14 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkWork.java ceb7b6c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkProcessAnalyzeTable.java 3a0f4c9

>   ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java 86d14f1 
> 
> Diff: https://reviews.apache.org/r/24195/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chao Sun
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message