hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 24211: HIVE-7554 - Parquet Hive should resolve column names in case insensitive manner
Date Mon, 04 Aug 2014 18:55:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24211/#review49483
-----------------------------------------------------------


Hi, mostly looks good, just a comment+question below.


ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/DataWritableReadSupport.java
<https://reviews.apache.org/r/24211/#comment86549>

    For easier-to-read code, can we not do the assignment in the call, and make a lower-case
version it in next line if necessary?
    
    Also is it indeed necessary in the next line to again use the lower-case version to lookup
from the map, or can we just do tableSchema.getType on the original col as in the earlier
case?


- Szehon Ho


On Aug. 4, 2014, 1:27 a.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24211/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 1:27 a.m.)
> 
> 
> Review request for hive and Szehon Ho.
> 
> 
> Bugs: HIVE-7554
>     https://issues.apache.org/jira/browse/HIVE-7554
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Resolves columns in a case insensitive manner. I also updated parquet_columnar.q as I
was concerned about some code in resolveSchemaAccess. It does not appear to be a problem but
I think the updated test covers more code.
> 
> 
> Diffs
> -----
> 
>   data/files/parquet_mixed_case PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/DataWritableReadSupport.java
c100dce 
>   ql/src/test/queries/clientpositive/parquet_columnar.q 4303d3e 
>   ql/src/test/queries/clientpositive/parquet_mixed_case.q PRE-CREATION 
>   ql/src/test/results/clientpositive/parquet_columnar.q.out 2222ff9 
>   ql/src/test/results/clientpositive/parquet_mixed_case.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24211/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message