hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke" <...@lars-francke.de>
Subject Re: Review Request 24137: allow disabling direct sql per query with external metastore
Date Fri, 01 Aug 2014 09:35:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24137/#review49330
-----------------------------------------------------------


Code style issues only


common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/24137/#comment86318>

    Should be named `META_CONFS`



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/24137/#comment86319>

    Should be named `META_CONF_VARS`
    
    Also all the `HiveConf` qualifiers are not necessary
    
    Indentation is 2 not 4 as per the Wiki



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/24137/#comment86320>

    Line too long



metastore/src/java/org/apache/hadoop/hive/metastore/IHMSHandler.java
<https://reviews.apache.org/r/24137/#comment86321>

    extra space between extends and ThriftHiveMetastore.Iface



metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
<https://reviews.apache.org/r/24137/#comment86322>

    `public` is not needed in interfaces



metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
<https://reviews.apache.org/r/24137/#comment86317>

    Javadoc is wrong



metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java
<https://reviews.apache.org/r/24137/#comment86323>

    no need to call getConf() here



metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java
<https://reviews.apache.org/r/24137/#comment86324>

    line too long



metastore/src/java/org/apache/hadoop/hive/metastore/events/ConfigChangeEvent.java
<https://reviews.apache.org/r/24137/#comment86325>

    line too long


- Lars Francke


On July 31, 2014, 1:34 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24137/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 1:34 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7532
>     https://issues.apache.org/jira/browse/HIVE-7532
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Currently with external metastore, direct sql can only be disabled via metastore config
globally. Perhaps it makes sense to have the ability to propagate the setting per query from
client to override the metastore setting, e.g. if one particular query causes it to fail.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3bfc681 
>   common/src/java/org/apache/hadoop/hive/conf/SystemVariables.java ee98d17 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
9e416b5 
>   metastore/if/hive_metastore.thrift 55f41db 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 5cc1cd8 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java d26183b

>   metastore/src/java/org/apache/hadoop/hive/metastore/IHMSHandler.java 1675751 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 5add436 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java c28c46a

>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStoreProxy.java 1cf09d4 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java 86172b9

>   metastore/src/java/org/apache/hadoop/hive/metastore/events/ConfigChangeEvent.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/24137/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message