hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke" <...@lars-francke.de>
Subject Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli
Date Fri, 01 Aug 2014 07:26:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23799/#review49325
-----------------------------------------------------------

Ship it!


Two last minor nit-picks. Apart from that it looks good! Thank you for taking care of all
my comments.


beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/23799/#comment86303>

    space missing



beeline/src/main/resources/BeeLine.properties
<https://reviews.apache.org/r/23799/#comment86305>

    I suggest
    
        specify the delimiter for delimiter-separated values output format (default: |)\n
\
    
    instead


- Lars Francke


On Aug. 1, 2014, 2:32 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23799/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 2:32 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7390
>     https://issues.apache.org/jira/browse/HIVE-7390
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-7390: refactor csv output format with in RFC mode and add one more option to support
formatting as the csv format in hive cli
> 
> 
> Diffs
> -----
> 
>   beeline/pom.xml 6ec1d1aff3f35c097aa6054aae84faf2d63854f1 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 528a98e29c23421f9352bdf7c5edd3a9fae0e3ea

>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 75f7d38cb97fb753a8f39c19488b9ce0a8d77590

>   beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 7853c3f38f3c3fb9ae0b9939c714f1dc940ba053

>   beeline/src/main/resources/BeeLine.properties 390d062b8dc52dfa790c7351f3db44c1e0dd7e37

>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f

>   pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d 
> 
> Diff: https://reviews.apache.org/r/23799/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message