hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 24086: HIVE-7348: Beeline could not parse ; separated queries provided with -e option
Date Fri, 01 Aug 2014 01:52:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24086/#review49318
-----------------------------------------------------------


Thanks for the test, mostly it looks good, I just had some minor comments.


itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
<https://reviews.apache.org/r/24086/#comment86284>

    Can we rename it so its like 'testQueryString' or more desciptive?  Test commands make
it seem like it will run commands against beeline.



itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
<https://reviews.apache.org/r/24086/#comment86283>

    We don't need 'copy' and can just pass in arglist right?  And while we're at it, can we
also remove the inner parens?


- Szehon Ho


On July 31, 2014, 8:05 a.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24086/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 8:05 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7348
>     https://issues.apache.org/jira/browse/HIVE-7348
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-7348: Beeline could not parse ; separated queries provided with -e option
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 10fd2e2daac78ca43d45c74fcbad6b720a8d28ad

>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f

> 
> Diff: https://reviews.apache.org/r/24086/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message