Return-Path: 
 <dev-return-95046-apmail-hive-dev-archive=hive.apache.org@hive.apache.org>
X-Original-To: apmail-hive-dev-archive@www.apache.org
Delivered-To: apmail-hive-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 526D31133C
	for <apmail-hive-dev-archive@www.apache.org>;
 Tue, 29 Jul 2014 23:12:39 +0000 (UTC)
Received: (qmail 64098 invoked by uid 500); 29 Jul 2014 23:12:38 -0000
Delivered-To: apmail-hive-dev-archive@hive.apache.org
Received: (qmail 63889 invoked by uid 500); 29 Jul 2014 23:12:38 -0000
Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hive.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hive.apache.org>
List-Post: <mailto:dev@hive.apache.org>
List-Id: <dev.hive.apache.org>
Reply-To: dev@hive.apache.org
Delivered-To: mailing list dev@hive.apache.org
Received: (qmail 63734 invoked by uid 500); 29 Jul 2014 23:12:38 -0000
Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org
Received: (qmail 63731 invoked by uid 99); 29 Jul 2014 23:12:38 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jul 2014 23:12:38 +0000
Date: Tue, 29 Jul 2014 23:12:38 +0000 (UTC)
From: "Lars Francke (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12715813.1400695358816.70894.1406675558728@arcas>
In-Reply-To: <JIRA.12715813.1400695358816@arcas>
References: <JIRA.12715813.1400695358816@arcas>
Subject: [jira] [Commented] (HIVE-7107) Clean up HiveDrivers and fix an
 issue
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HIVE-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078567#comment-14078567 ] 

Lars Francke commented on HIVE-7107:
------------------------------------

https://reviews.apache.org/r/24076/

I realize that HS1 is scheduled to be removed but I submitted this before 0.13.1 was released and maybe 0.13.2 will be released still. Also I think there's a chance that some distributions will keep HS1 in for a bit longer and this patch fixes an issue with it. I also don't see any harm in maintaining code that's scheduled to be removed at some point.

> Clean up HiveDrivers and fix an issue
> -------------------------------------
>
>                 Key: HIVE-7107
>                 URL: https://issues.apache.org/jira/browse/HIVE-7107
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-7107.2.patch
>
>
> The HiveServer1 driver does not adhere to the JDBC standard of returning null when it can't handle a connection URL. It instead throws an exception which leads to subsequent exceptions (from other drivers, i.e. the HiveServer2 one) being swallowed.
> This is what you'd see:
> {quote}
> Error: Invalid URL: jdbc:hive2://localhost:10000/default;principal=hive/_HOST@EXAMPLE.COM (state=08S01,code=0)
> java.sql.SQLException: Invalid URL: jdbc:hive2://localhost:10000/default;principal=hive/_HOST@EXAMPLE.COM
> 	at org.apache.hadoop.hive.jdbc.HiveConnection.<init>(HiveConnection.java:86)
> {quote}
> In addition this patch cleans up the drivers a bit.



--
This message was sent by Atlassian JIRA
(v6.2#6252)