Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6FDCB11B8D for ; Thu, 17 Jul 2014 19:05:23 +0000 (UTC) Received: (qmail 58541 invoked by uid 500); 17 Jul 2014 19:05:23 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 58470 invoked by uid 500); 17 Jul 2014 19:05:23 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 58440 invoked by uid 99); 17 Jul 2014 19:05:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jul 2014 19:05:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5FA311DB8AC; Thu, 17 Jul 2014 19:05:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3257912827250713008==" MIME-Version: 1.0 Subject: Re: Review Request 23425: HIVE-7361: using authorization api for RESET, DFS, ADD, DELETE, COMPILE commands From: "Thejas Nair" To: "Vijayakumar Ramdoss" , "Thejas Nair" , "Jason Dere" , "hive" Date: Thu, 17 Jul 2014 19:05:10 -0000 Message-ID: <20140717190510.14170.93279@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/23425/ X-Sender: "Thejas Nair" References: <20140717011655.14170.63191@reviews.apache.org> In-Reply-To: <20140717011655.14170.63191@reviews.apache.org> Reply-To: "Thejas Nair" X-ReviewRequest-Repository: hive-git --===============3257912827250713008== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On July 17, 2014, 1:16 a.m., Jason Dere wrote: > > ql/src/test/queries/clientnegative/authorization_dfs.q, line 4 > > > > > > Looks like authorization_dfs.q no longer requires an initial query to initialize auth, whereas authorization_reset.q, authorization_admin_almighty2.q still have one. Should it be removed from those q files? removing it from authorization_reset.q. In authorization_admin_almighty2.q it is there as a way to enable me to add a comment (not for any auth init)!! hive throws a syntax error if a comment is there before any of the command processor commands!!!! - Thejas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23425/#review47978 ----------------------------------------------------------- On July 16, 2014, 10:10 p.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23425/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 10:10 p.m.) > > > Review request for hive. > > > Bugs: HIVE-7361 > https://issues.apache.org/jira/browse/HIVE-7361 > > > Repository: hive-git > > > Description > ------- > > See jira HIVE-7361. > > > Diffs > ----- > > conf/hive-default.xml.template ba5b8a9 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcWithSQLAuthorization.java abe5ffa > itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessControllerForTest.java 4474ce5 > itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java PRE-CREATION > itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactoryForTest.java 89e18b3 > ql/src/java/org/apache/hadoop/hive/ql/processors/AddResourceProcessor.java 0532666 > ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java f29a409 > ql/src/java/org/apache/hadoop/hive/ql/processors/CommandUtil.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java 8b8475b > ql/src/java/org/apache/hadoop/hive/ql/processors/DeleteResourceProcessor.java bfac5f8 > ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java d343a3c > ql/src/java/org/apache/hadoop/hive/ql/processors/ResetProcessor.java b8ecfad > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java 0537b92 > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObject.java db57cb6 > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/GrantPrivAuthUtils.java f99109b > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 151df6a > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java beb45f5 > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java f2a4004 > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 8937cfa > ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveOperationType.java b990cb2 > ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessController.java 06f9258 > ql/src/test/queries/clientnegative/authorization_addjar.q a1709da > ql/src/test/queries/clientnegative/authorization_compile.q PRE-CREATION > ql/src/test/queries/clientnegative/authorization_deletejar.q PRE-CREATION > ql/src/test/queries/clientnegative/authorization_dfs.q 7d47a7b > ql/src/test/queries/clientpositive/authorization_admin_almighty2.q PRE-CREATION > ql/src/test/queries/clientpositive/authorization_reset.q PRE-CREATION > ql/src/test/results/clientnegative/authorization_addjar.q.out d206dca > ql/src/test/results/clientnegative/authorization_addpartition.q.out 6331ae2 > ql/src/test/results/clientnegative/authorization_alter_db_owner.q.out 550cbcc > ql/src/test/results/clientnegative/authorization_alter_db_owner_default.q.out 4df868e > ql/src/test/results/clientnegative/authorization_compile.q.out PRE-CREATION > ql/src/test/results/clientnegative/authorization_create_func1.q.out 7c72092 > ql/src/test/results/clientnegative/authorization_create_func2.q.out 7c72092 > ql/src/test/results/clientnegative/authorization_create_macro1.q.out 7c72092 > ql/src/test/results/clientnegative/authorization_createview.q.out c86bdfa > ql/src/test/results/clientnegative/authorization_ctas.q.out f8395b7 > ql/src/test/results/clientnegative/authorization_deletejar.q.out PRE-CREATION > ql/src/test/results/clientnegative/authorization_desc_table_nosel.q.out be56d34 > ql/src/test/results/clientnegative/authorization_dfs.q.out d685e78 > ql/src/test/results/clientnegative/authorization_drop_db_cascade.q.out 74ab4c8 > ql/src/test/results/clientnegative/authorization_drop_db_empty.q.out bd7447f > ql/src/test/results/clientnegative/authorization_droppartition.q.out 1da250a > ql/src/test/results/clientnegative/authorization_grant_table_allpriv.q.out 4aa7058 > ql/src/test/results/clientnegative/authorization_grant_table_fail1.q.out f042c1e > ql/src/test/results/clientnegative/authorization_grant_table_fail_nogrant.q.out a906a70 > ql/src/test/results/clientnegative/authorization_insert_noinspriv.q.out 8de1104 > ql/src/test/results/clientnegative/authorization_insert_noselectpriv.q.out 46ada3b > ql/src/test/results/clientnegative/authorization_insertoverwrite_nodel.q.out fa0f7f7 > ql/src/test/results/clientnegative/authorization_not_owner_alter_tab_rename.q.out 8a7f2d2 > ql/src/test/results/clientnegative/authorization_not_owner_alter_tab_serdeprop.q.out 8a7f2d2 > ql/src/test/results/clientnegative/authorization_not_owner_drop_tab.q.out 4378b12 > ql/src/test/results/clientnegative/authorization_not_owner_drop_view.q.out 80378ac > ql/src/test/results/clientnegative/authorization_priv_current_role_neg.q.out a62b7b3 > ql/src/test/results/clientnegative/authorization_rolehierarchy_privs.q.out 9f99d6f > ql/src/test/results/clientnegative/authorization_select.q.out f8395b7 > ql/src/test/results/clientnegative/authorization_select_view.q.out f253870 > ql/src/test/results/clientnegative/authorization_show_parts_nosel.q.out bd502d1 > ql/src/test/results/clientnegative/authorization_truncate.q.out 4d51bc4 > ql/src/test/results/clientnegative/authorize_create_tbl.q.out ec75b1d > ql/src/test/results/clientnegative/temp_table_authorize_create_tbl.q.out ec75b1d > ql/src/test/results/clientpositive/authorization_admin_almighty2.q.out PRE-CREATION > ql/src/test/results/clientpositive/authorization_reset.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/23425/diff/ > > > Testing > ------- > > New tests included. > > > Thanks, > > Thejas Nair > > --===============3257912827250713008==--