Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============2571958091519435122=="
MIME-Version: 1.0
Subject: Review Request 23350: Queries without tables fail under Tez
From: "Navis Ryu" <navis.ryu@nexr.com>
To: "Navis Ryu" <navis.ryu@nexr.com>, "hive" <dev@hive.apache.org>
Date: Wed, 09 Jul 2014 06:53:56 -0000
Message-ID: <20140709065356.17971.68655@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Navis Ryu" <noreply@reviews.apache.org>
Reply-To: "Navis Ryu" <navis.ryu@nexr.com>

--===============2571958091519435122==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23350/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-7352
    https://issues.apache.org/jira/browse/HIVE-7352


Repository: hive-git


Description
-------

Hive 0.13.0 added support for queries that do not reference tables (such as 'SELECT 1'). These queries fail under Tez:

{noformat}
Vertex failed as one or more tasks failed. failedTasks:1]
14/07/07 09:54:42 ERROR tez.TezJobMonitor: Vertex failed, vertexName=Map 1, vertexId=vertex_1404652697071_4487_1_00, diagnostics=[Task failed, taskId=task_1404652697071_4487_1_00_000000, diagnostics=[AttemptID:attempt_1404652697071_4487_1_00_000000_0 Info:Error: java.lang.RuntimeException: java.lang.IllegalArgumentException: Can not create a Path from an empty string
	at org.apache.hadoop.mapred.split.TezGroupedSplitsInputFormat$TezGroupedSplitsRecordReader.initNextRecordReader(TezGroupedSplitsInputFormat.java:174)
	at org.apache.hadoop.mapred.split.TezGroupedSplitsInputFormat$TezGroupedSplitsRecordReader.<init>(TezGroupedSplitsInputFormat.java:113)
	at org.apache.hadoop.mapred.split.TezGroupedSplitsInputFormat.getRecordReader(TezGroupedSplitsInputFormat.java:79)
	at org.apache.tez.mapreduce.input.MRInput.setupOldRecordReader(MRInput.java:205)
	at org.apache.tez.mapreduce.input.MRInput.initFromEventInternal(MRInput.java:362)
	at org.apache.tez.mapreduce.input.MRInput.initFromEvent(MRInput.java:341)
	at org.apache.tez.mapreduce.input.MRInputLegacy.checkAndAwaitRecordReaderInitialization(MRInputLegacy.java:99)
	at org.apache.tez.mapreduce.input.MRInputLegacy.init(MRInputLegacy.java:68)
	at org.apache.hadoop.hive.ql.exec.tez.TezProcessor.run(TezProcessor.java:141)
	at org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.run(LogicalIOProcessorRuntimeTask.java:307)
	at org.apache.hadoop.mapred.YarnTezDagChild$5.run(YarnTezDagChild.java:562)
	at java.security.AccessController.doPrivileged(Native Method)
	at javax.security.auth.Subject.doAs(Subject.java:415)
	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1491)
	at org.apache.hadoop.mapred.YarnTezDagChild.main(YarnTezDagChild.java:551)
Caused by: java.lang.IllegalArgumentException: Can not create a Path from an empty string
	at org.apache.hadoop.fs.Path.checkPathArg(Path.java:127)
	at org.apache.hadoop.fs.Path.<init>(Path.java:135)
	at org.apache.hadoop.hive.ql.io.HiveInputFormat$HiveInputSplit.getPath(HiveInputFormat.java:110)
	at org.apache.hadoop.hive.ql.io.HiveInputFormat.getRecordReader(HiveInputFormat.java:228)
	at org.apache.hadoop.mapred.split.TezGroupedSplitsInputFormat$TezGroupedSplitsRecordReader.initNextRecordReader(TezGroupedSplitsInputFormat.java:171)
	... 14 more
{noformat}


Diffs
-----

  itests/qtest/testconfiguration.properties 1462ecd 
  ql/src/java/org/apache/hadoop/hive/ql/io/NullRowsInputFormat.java fd60fed 
  ql/src/test/results/clientpositive/tez/select_dummy_source.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/23350/diff/


Testing
-------


Thanks,

Navis Ryu


--===============2571958091519435122==--