hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7409) Add workaround for a deadlock issue of Class.getAnnotation()
Date Wed, 16 Jul 2014 04:23:05 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063119#comment-14063119
] 

Xuefu Zhang commented on HIVE-7409:
-----------------------------------

Not sure if I follow completely. JDK-7031759 is caused by calling getAnnotations() from sysnchronized
static method. However, I don't see any of getAnnotations calls is called from such kind of
method, including isStateful.

Just curious, have you seen such deadlock occurring in Hive? I can undersatnd if your patch
is for the sake of precaution. Nevertheless, I think we should probably create an utility
method for this so that we don't have to repeat the same code pattern.

> Add workaround for a deadlock issue of Class.getAnnotation() 
> -------------------------------------------------------------
>
>                 Key: HIVE-7409
>                 URL: https://issues.apache.org/jira/browse/HIVE-7409
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Tsuyoshi OZAWA
>         Attachments: HIVE-7409.1.patch
>
>
> [JDK-7122142|https://bugs.openjdk.java.net/browse/JDK-7122142] mentions that there is
a race condition in getAnnotations. This problem can lead deadlock. The fix on JDK will be
merged on jdk8, but hive supports jdk6/jdk7 currently. Therefore, we should add workaround
to avoid the issue.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message