hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7409) Add workaround for a deadlock issue of Class.getAnnotation()
Date Tue, 22 Jul 2014 01:08:39 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069637#comment-14069637
] 

Xuefu Zhang commented on HIVE-7409:
-----------------------------------

Patch looks good. +1. There seems a minor format issue:
{code}
+		WindowFunctionDescription def =
+        AnnotationUtils.getAnnotation(wfnCls, WindowFunctionDescription.class);
{code}
This can be addressed in a subsequent JIRA if confirmed.

> Add workaround for a deadlock issue of Class.getAnnotation() 
> -------------------------------------------------------------
>
>                 Key: HIVE-7409
>                 URL: https://issues.apache.org/jira/browse/HIVE-7409
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>             Fix For: 0.14.0
>
>         Attachments: HIVE-7409.1.patch, HIVE-7409.2.patch.txt, stacktrace.txt
>
>
> [JDK-7122142|https://bugs.openjdk.java.net/browse/JDK-7122142] mentions that there is
a race condition in getAnnotations. This problem can lead deadlock. The fix on JDK will be
merged on jdk8, but hive supports jdk6/jdk7 currently. Therefore, we should add workaround
to avoid the issue.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message